Add FilterState action. #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbp
added
the
parser generator
nbp
force-pushed
the
add-filter-states-action
branch
from
1454a93 to
856dcf8
Compare
jorendorff
approved these changes
Jun 12, 2020
nbp
force-pushed
the
add-filter-states-action
branch
from
856dcf8 to
f30728f
Compare
nbp
force-pushed
the
add-filter-states-action
branch
from
f30728f to
ce99326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is part of #430 and add the
FilterStatesaction as well as the code it produces in both the Python and Rust backend.At the moment no phase of the parse table is making use of this code, but this would be part of the upcoming PR.
@jorendorff I think you might want to give a look at these changes as it is a corner stone from moving away from the default style of parse tables.