Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action.py reports TypeError instead of NotImplementedError #574

Open
nbp opened this issue Jun 22, 2020 · 0 comments
Open

action.py reports TypeError instead of NotImplementedError #574

nbp opened this issue Jun 22, 2020 · 0 comments
Labels
good first issue Good for newcomers parser generator Bug related to the grammar processing, parse tebale generator and the parse table backends.

Comments

@nbp
Copy link
Collaborator

nbp commented Jun 22, 2020

Many functions under the generic action.py are reporting TypeError messages where they should assert whether it is valid to call the function in the first place, and then report NotImplementedError after.

For example: #562 (comment)
@nbp nbp added good first issue Good for newcomers parser generator Bug related to the grammar processing, parse tebale generator and the parse table backends. labels Jun 22, 2020
@nbp nbp mentioned this issue Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers parser generator Bug related to the grammar processing, parse tebale generator and the parse table backends.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nbp