This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
string-import-02-25-2024 #4055
Merged
string-import-02-25-2024 #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Delphine tagging you for review because I'm not sure about those changes, if they are correct or not.. |
|
@isabelrios Hmm I don't see anything concerning looking at this. But is there something in particular that you've noticed and you think could be an error in this string import PR? |
isabelrios
reviewed
Feb 27, 2024
| @@ -44,7 +44,7 @@ | |||
| "actionSheet.openIn" = "Відкрити в %@"; | |||
|
|
|||
| /* Button to dismiss the 'Add Pass Failed' alert. */ | |||
| "AddPass.Error.Dismiss" = "Гаразд"; | |||
| "AddPass.Error.Dismiss" = "OK"; | |||
There was a problem hiding this comment.
@Delphine I was surprised about this change which seems like undoing a translated string...
There was a problem hiding this comment.
Oh I see! Some languages actually decide to use "OK" in some cases. I've checked across other strings and seems like this is expected for Ukrainian. Thanks for checking!
There was a problem hiding this comment.
Sounds good to me then! Thanks!
isabelrios
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (automated) PR import string changes