Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove accidentally leaked apis #1393

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: remove accidentally leaked apis #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe95ef0
ci: show inconsistent api
peter-jerry-ye Dec 31, 2024
11fb3fc
fix: remove accidentally leaked types
peter-jerry-ye Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,13 @@ jobs:
moonrun --version

- name: moon check
run: moon check --deny-warn
run: moon check --deny-warn --target all

- name: moon info
run: |
moon info
git diff --exit-code
diff <(mooninfo target/js/release/check/builtin/builtin.mi -format text) <(mooninfo target/wasm-gc/release/check/builtin/builtin.mi -format text)

- name: Set ulimit and run moon test
if: ${{ matrix.os != 'windows-latest' }}
Expand Down
2 changes: 1 addition & 1 deletion array/array_js.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

///|
type JSArray
priv type JSArray

///|
fn JSArray::ofAnyArray[T](array : Array[T]) -> JSArray = "%identity"
Expand Down
4 changes: 2 additions & 2 deletions builtin/arraycore_js.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// generic type parameters of extern ffi

///|
type JSValue
priv type JSValue

///|
fn JSValue::ofAny[T](array : T) -> JSValue = "%identity"
Expand All @@ -26,7 +26,7 @@ fn JSValue::ofAny[T](array : T) -> JSValue = "%identity"
fn JSValue::toAny[T](self : JSValue) -> T = "%identity"

///|
type JSArray
priv type JSArray

///|
fn JSArray::ofAnyArray[T](array : Array[T]) -> JSArray = "%identity"
Expand Down
2 changes: 1 addition & 1 deletion builtin/int64_js.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ fn MyInt64::op_mul(self : MyInt64, other : MyInt64) -> MyInt64 {
}

///|
struct Int64WasmHelper {
priv struct Int64WasmHelper {
div_s : (Int, Int, Int, Int) -> Int
div_u : (Int, Int, Int, Int) -> Int
rem_s : (Int, Int, Int, Int) -> Int
Expand Down
Loading