-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove accidentally leaked apis #1393
base: main
Are you sure you want to change the base?
Conversation
Here are three observations from the provided
These changes seem to be focused on improving the robustness and maintainability of the code, but they should be carefully reviewed to avoid introducing new issues. |
Pull Request Test Coverage Report for Build 4564Details
💛 - Coveralls |
builtin/int64_nonjs.mbt
Outdated
@@ -177,7 +177,7 @@ pub fn Double::reinterpret_as_u64(self : Double) -> UInt64 = "%f64_to_i64_reinte | |||
///| | |||
pub fn Double::reinterpret_as_uint64(self : Double) -> UInt64 = "%f64_to_i64_reinterpret" | |||
|
|||
///| | |||
///| @alert deprecated "Use `UInt64::to_double` instead" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UInt64 is not safe to represent in Double. I think UInt64::to_double
is not a good name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is as good / bad as (int)1.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not do two things in a single PR, can you split your changes (as tilte) into a single PR?
991edaf
to
11fb3fc
Compare
No description provided.