-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AttentionBox): add prop for enter animation #2566
Merged
rivka-ungar
merged 5 commits into
master
from
attentionbox-add-option-for-animation-7719404878
Oct 29, 2024
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a4303d
feat(AttentionBox): add prop for enter animation
rivka-ungar 7dded2d
add to storybook
rivka-ungar 7021e62
add option to close attentionBox in story
rivka-ungar c2516c7
update description
rivka-ungar 734f483
add description for prop
rivka-ungar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import React from "react"; | ||
import React, { useState } from "react"; | ||
import { useCallback } from "react"; | ||
import AttentionBox from "../AttentionBox"; | ||
import { createStoryMetaSettingsDecorator } from "../../../storybook"; | ||
|
@@ -13,6 +13,7 @@ import Flex from "../../Flex/Flex"; | |
import Favorite from "../../Icon/Icons/components/Favorite"; | ||
import AttentionBoxLink from "../AttentionBoxLink/AttentionBoxLink"; | ||
import "./AttentionBox.stories.scss"; | ||
import Button from "../../Button/Button"; | ||
|
||
const metaSettings = createStoryMetaSettingsDecorator({ | ||
component: AttentionBox, | ||
|
@@ -181,3 +182,38 @@ export const AttentionBoxInsideADialogCombobox = { | |
|
||
name: "Attention box inside a dialog/combobox" | ||
}; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also add live edit? |
||
export const AttentionBoxAnimation = { | ||
render: () => { | ||
const [isOpen, setOpen] = useState(false); | ||
const onClick = useCallback(() => { | ||
setOpen(true); | ||
}, []); | ||
return ( | ||
<> | ||
<Flex | ||
gap={Flex.gaps.MEDIUM} | ||
style={{ | ||
height: "44px" | ||
}} | ||
> | ||
<Button onClick={onClick} kind={Button.kinds.SECONDARY}> | ||
Entry animation | ||
</Button> | ||
{isOpen && ( | ||
<AttentionBox | ||
compact | ||
withIconWithoutHeader | ||
entryAnimation | ||
icon={Info} | ||
text="First, move the content you want to copy into folder. Only main boards and dashboards can be copied." | ||
onClose={() => setOpen(false)} | ||
/> | ||
)} | ||
</Flex> | ||
</> | ||
); | ||
}, | ||
|
||
name: "Attention box inside a dialog/combobox" | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to this prop :)