feat(AttentionBox): add prop for enter animation #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
approved these changes
Oct 28, 2024
| @@ -71,7 +73,9 @@ const AttentionBox: React.FC<AttentionBoxProps> & { | |||
|
|
|||
| return ( | |||
| <aside | |||
| className={cx(styles.attentionBox, getStyle(styles, camelCase(`type-${type}`)), overrideClassName)} | |||
| className={cx(styles.attentionBox, getStyle(styles, camelCase(`type-${type}`)), overrideClassName, { | |||
| [styles.animateOnEnter]: animateOnEnter | |||
There was a problem hiding this comment.
should this class be removed after the animation ends? or does the animation just works once and you don't care about it afterwards?
There was a problem hiding this comment.
ok nm, I don't think it matters
shaharzil
reviewed
Oct 29, 2024
| @@ -36,6 +36,7 @@ export interface AttentionBoxProps extends VibeComponentProps { | |||
| onClose?: (event: React.MouseEvent) => void; | |||
| compact?: boolean; | |||
| closeButtonAriaLabel?: string; | |||
| entryAnimation?: boolean; | |||
There was a problem hiding this comment.
Please add a description to this prop :)
| @@ -181,3 +182,38 @@ export const AttentionBoxInsideADialogCombobox = { | |||
|
|
|||
| name: "Attention box inside a dialog/combobox" | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Maybe also add live edit?
shaharzil
approved these changes
Oct 29, 2024
rivka-ungar
deleted the
attentionbox-add-option-for-animation-7719404878
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/7719404878