Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Modal): control autofocus and keyboard navigation focus #2556

Merged
merged 3 commits into from
Oct 28, 2024
Merged

feat(Modal): control autofocus and keyboard navigation focus #2556

merged 3 commits into from
Oct 28, 2024

Conversation

YossiSaadi
Copy link
Contributor

  • Always start autofocus cycle on content
  • Skip top actions (close button + render action) from autofocusing on first focus cycle of modal

https://monday.monday.com/boards/3532714909/pulses/7360929204

@YossiSaadi YossiSaadi requested a review from a team as a code owner October 20, 2024 16:34
rivka-ungar
rivka-ungar approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@rivka-ungar rivka-ungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@YossiSaadi YossiSaadi merged commit 993e9f4 into feat/yossi/new-modal-building-blocks-7359960492 Oct 28, 2024
9 of 10 checks passed
@YossiSaadi YossiSaadi deleted the feat/yossi/modal-a11y-keyboard-navigation-order-7360929204 branch October 28, 2024 12:48
@YossiSaadi YossiSaadi mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rivka-ungar rivka-ungar rivka-ungar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YossiSaadi @rivka-ungar