-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Modal): new Modal components building blocks #2432
Merged
YossiSaadi
merged 17 commits into
master
from
feat/yossi/new-modal-building-blocks-7359960492
Dec 2, 2024
Merged
feat(Modal): new Modal components building blocks #2432
YossiSaadi
merged 17 commits into
master
from
feat/yossi/new-modal-building-blocks-7359960492
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
force-pushed
the
feat/yossi/new-modal-building-blocks-7359960492
branch
from
September 12, 2024 16:52
dc9d8e1
to
3f8faa6
Compare
…ow setting those values through context (#2420)
YossiSaadi
force-pushed
the
feat/yossi/new-modal-building-blocks-7359960492
branch
from
October 14, 2024 10:30
153d94f
to
23b868f
Compare
…locks-7359960492 # Conflicts: # packages/core/package.json # yarn.lock
YossiSaadi
deleted the
feat/yossi/new-modal-building-blocks-7359960492
branch
December 2, 2024 15:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Modal
This PR includes:
ModalHeader
:ModalContent
:ModalTopActions
:Modal
- which should act as an empty canvas which manages all the logic behind a modal concept:ModalFooterBase
- acts as a base component for wizard and regular footer usages:Keyboard navigation and autofocus:
Animations: