docs(DialogContentContainer): replace inline strings with Vibe's Text component #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
changed the title
YossiSaadi
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @noyshlomo! congrats on your first contribution to Vibe :)
|
@noyshlomo please the CI fails because you have a redundant space in line 4 |
|
Resolves #2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
This PR replaces the inline string in the DialogContentContainer located in
packages/core/src/storybook/components/related-components/descriptions/dialog-content-container.jsxwith Vibe's Text component.Motivation for these changes:
Currently, the DialogContentContainer uses inline strings, which leads to theme inconsistencies, particularly in dark mode. By implementing the Text component, we can ensure proper styling and a consistent appearance across different themes.
Impact on the project:
This update resolves the styling issues related to dark themes and aligns with Vibe's design specifications, enhancing the user experience.
Link to the issue
I have read the Contribution Guide for this project.