Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DialogContentContainer catalog component to use Text component #2508

Closed
YossiSaadi opened this issue Oct 13, 2024 · 2 comments · Fixed by #2524
Closed

Change DialogContentContainer catalog component to use Text component #2508

YossiSaadi opened this issue Oct 13, 2024 · 2 comments · Fixed by #2524
Assignees
Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest

Comments

@YossiSaadi
Copy link
Contributor

In the file of:
packages/core/src/storybook/components/related-components/descriptions/dialog-content-container.jsx
which can be seen on our Catalog page, we do not currently use Vibe's Text component, but instead use inline string.
It also causes theme issues where a story doesn't look right on dark themes.

<DialogContentContainer>
  <p>A content section within an elevated dialog content container</p>
</DialogContentContainer>

--> Something like

<DialogContentContainer>
  <Text ellipsis={false}>A content section within an elevated dialog content container</Text>
</DialogContentContainer>

Notice the ellipsis as false as well.

monday ticket:
https://monday.monday.com/boards/3532714909/pulses/7080412658

@YossiSaadi YossiSaadi added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest labels Oct 13, 2024
@noyshlomo
Copy link
Contributor

Hi, Can you please assign this to me?

@YossiSaadi
Copy link
Contributor Author

@noyshlomo go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants