feat(Modal): add pop from center/anchor animations #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
force-pushed
the
feat/yossi/new-modal-building-blocks-7359960492
branch
from
153d94f to
23b868f
Compare
YossiSaadi
force-pushed
the
feat/yossi/new-modal-modal-animation-add-animation-for-modal-opening-7586333722
branch
from
2db54e9 to
9acf136
Compare
YossiSaadi
changed the title
YossiSaadi
force-pushed
the
feat/yossi/new-modal-modal-animation-add-animation-for-modal-opening-7586333722
branch
from
ba0fb26 to
b4c0e00
Compare
rivka-ungar
reviewed
Oct 29, 2024
| opacity: [0, 1, 1], | ||
| scale: [0.65, 0.65, 1], | ||
| top: "50%", | ||
| left: "50%", |
There was a problem hiding this comment.
Are the top & left needed here as they are defined already in the css?
There was a problem hiding this comment.
yep, the css determines their first positioning and then I need to reflect it also here, otherwise its positioning is messed up
rivka-ungar
reviewed
Oct 29, 2024
| initial="exit" | ||
| animate="enter" | ||
| exit="exit" | ||
| custom={anchorElementRef} |
There was a problem hiding this comment.
Does this need a fallback in case it is undefined, so it won't mess up the animation?
There was a problem hiding this comment.
checked it, if it is undefined then the pop from center variation would be applied and it doesn't use it
if it is being used from custom, then the pop from anchor variation would be applied, and it means that the anchor element ref isn't undefined
rivka-ungar
approved these changes
Oct 29, 2024
YossiSaadi
merged commit 9b53547
into
feat/yossi/new-modal-building-blocks-7359960492
9 of 10 checks passed
YossiSaadi
deleted the
feat/yossi/new-modal-modal-animation-add-animation-for-modal-opening-7586333722
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/7586333722
https://monday.monday.com/boards/3532714909/pulses/7586334945