Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ModalMediaLayout): layout with top media for new Modal #2465

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
.layout {
width: 100%;
flex-grow: 1;
overflow: hidden;

.media {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it's an image? object-fit needed? Will be used externally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be supplied through recommended ModalMedia. if users don't want to use ModalMedia for some reason they'll be responsible for stretching the image

width: 100%;
height: var(--modal-top-media-height, 240px);
flex-shrink: 0;

@media (min-width: 1280px) {
--modal-top-media-height: 260px;
}

@media (min-width: 1440px) {
--modal-top-media-height: 260px;
}

@media (min-width: 1720px) {
--modal-top-media-height: 320px;
}
}

.header {
width: 100%;
margin-block: var(--spacing-large) var(--spacing-small);
text-align: center;
}

.content {
width: 100%;
flex: 1;
align-self: flex-start;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import React, { forwardRef } from "react";
import cx from "classnames";
import { getTestId } from "../../../../tests/test-ids-utils";
import { ComponentDefaultTestId } from "../../../../tests/constants";
import styles from "./ModalMediaLayout.module.scss";
import { ModalMediaLayoutProps } from "./ModalMediaLayout.types";
import Flex from "../../../Flex/Flex";

const ModalMediaLayout = forwardRef(
(
{ children, className, id, "data-testid": dataTestId }: ModalMediaLayoutProps,
ref: React.ForwardedRef<HTMLDivElement>
) => {
const [media, header, content] = React.Children.toArray(children);

return (
<Flex
ref={ref}
direction={Flex.directions.COLUMN}
align={Flex.align.START}
className={cx(styles.layout, className)}
id={id}
data-testid={dataTestId || getTestId(ComponentDefaultTestId.MODAL_NEXT_MEDIA_LAYOUT, id)}
>
<div className={styles.media}>{media}</div>
<div className={styles.header}>{header}</div>
<div className={styles.content}>{content}</div>
</Flex>
);
}
);

export default ModalMediaLayout;
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import React from "react";
import { VibeComponentProps } from "../../../../types";

export interface ModalMediaLayoutProps extends VibeComponentProps {
children: React.ReactNode;
}
1 change: 1 addition & 0 deletions packages/core/src/tests/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export enum ComponentDefaultTestId {
MODAL_NEXT_MEDIA = "modal-media",
MODAL_NEXT_BASIC_LAYOUT = "modal-basic-layout",
MODAL_NEXT_SIDE_BY_SIDE_LAYOUT = "modal-side-by-side-layout",
MODAL_NEXT_MEDIA_LAYOUT = "modal-media-layout",
FORMATTED_NUMBER = "formatted-number",
HIDDEN_TEXT = "hidden-text",
DIALOG_CONTENT_CONTAINER = "dialog-content-container",
Expand Down