Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ModalMediaLayout): layout with top media for new Modal #2465

Merged
merged 4 commits into from
Oct 20, 2024
Merged

feat(ModalMediaLayout): layout with top media for new Modal #2465

merged 4 commits into from
Oct 20, 2024

Conversation

YossiSaadi
Copy link
Contributor

@YossiSaadi YossiSaadi commented Oct 8, 2024 •
edited
Loading

MediaLayout

image

Usage example:

<Modal size="large">
  <ModalMediaLayout>
    <ModalMedia><img src="imgUrl" alt="I'm image" /></ModalMedia>
    <ModalHeader title="I'm title" />
    <ModalContent>I'm content</ModalContent>
  </ModalSideBySideLayout>
  <ModalFooter /> // TBD
</Modal>

https://monday.monday.com/boards/3532714909/pulses/7360990175

@YossiSaadi YossiSaadi marked this pull request as ready for review October 14, 2024 12:28
@YossiSaadi YossiSaadi requested a review from a team as a code owner October 14, 2024 12:28
@YossiSaadi YossiSaadi force-pushed the feat/yossi/new-modal-sidebyside-layout-7360989345 branch from dba9e3b to 9d43dca Compare October 14, 2024 13:19
@YossiSaadi YossiSaadi force-pushed the feat/yossi/new-modal-hero-layout-7360990175 branch from 8f2ee29 to d5eeac5 Compare October 14, 2024 13:25
talkor
talkor approved these changes Oct 15, 2024
View reviewed changes
packages/core/src/components/ModalNew/layouts/ModalMediaLayout/ModalMediaLayout.module.scss
flex-grow: 1;
overflow: hidden;

.media {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it's an image? object-fit needed? Will be used externally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be supplied through recommended ModalMedia. if users don't want to use ModalMedia for some reason they'll be responsible for stretching the image

@YossiSaadi YossiSaadi mentioned this pull request Oct 20, 2024
Merged
@YossiSaadi YossiSaadi force-pushed the feat/yossi/new-modal-sidebyside-layout-7360989345 branch from 917339d to 3ebfe5b Compare October 20, 2024 11:48
Base automatically changed from feat/yossi/new-modal-sidebyside-layout-7360989345 to feat/yossi/new-modal-layouts October 20, 2024 12:00
An error occurred while trying to automatically change base from feat/yossi/new-modal-sidebyside-layout-7360989345 to feat/yossi/new-modal-layouts October 20, 2024 12:00
@YossiSaadi YossiSaadi force-pushed the feat/yossi/new-modal-hero-layout-7360990175 branch from d5eeac5 to 6df9cd8 Compare October 20, 2024 12:04
@YossiSaadi YossiSaadi merged commit 9e0ece3 into feat/yossi/new-modal-layouts Oct 20, 2024
4 checks passed
@YossiSaadi YossiSaadi deleted the feat/yossi/new-modal-hero-layout-7360990175 branch October 20, 2024 12:14
YossiSaadi added a commit that referenced this pull request Dec 2, 2024
@YossiSaadi
feat(ModalMediaLayout): layout with top media for new Modal (#2465)
a16fa79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YossiSaadi @talkor