feat(Modal): handle onClose and show logic of component #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
approved these changes
Sep 24, 2024
packages/core/src/components/ModalNew/ModalTopActions/ModalTopActions.types.ts
Outdated
Show resolved
Hide resolved
| useKeyEvent({ | ||
| callback: onEscClick, | ||
| capture: true, | ||
| keys: ["Escape"] |
There was a problem hiding this comment.
I think we have consts for these
There was a problem hiding this comment.
Will change for now, but I think we should make useKeyEvent use string keys as well, same as we switched from static props to inline string props
can be a non-breaking change after we release Vibe3
There was a problem hiding this comment.
it can be
we can extract the keys strings from React's TS I believe
| @@ -27,6 +28,16 @@ describe("Modal", () => { | |||
| expect(getByTestId("modal")).toHaveAttribute("aria-modal", "true"); | |||
| }); | |||
|
|
|||
| it("does not render when 'show' is false", () => { | |||
There was a problem hiding this comment.
Suggested change
| it("does not render when 'show' is false", () => { | |
| it("should not render when 'show' is false", () => { |
There was a problem hiding this comment.
I've wrote all the tests not in a should style (by mistake, accidentally ignored Gebeta's chosen style)
planning on changing all the tests names later 😓
YossiSaadi
force-pushed
the
feat/yossi/modal-take-care-of-aria-labelledby-and-aria-describedby-7367625236
branch
2 times, most recently
from
7db7139 to
d2ba886
Compare
Base automatically changed from
feat/yossi/modal-take-care-of-aria-labelledby-and-aria-describedby-7367625236
to
feat/yossi/new-modal-building-blocks-7359960492
September 24, 2024 15:20
An error occurred while trying to automatically change base from
feat/yossi/modal-take-care-of-aria-labelledby-and-aria-describedby-7367625236
to
feat/yossi/new-modal-building-blocks-7359960492
September 24, 2024 15:20
…licking Escape clicking on X to close modal has already implemented at earlier commits
it can be either a MouseEvent of clicking a button ("x" close button), clicking on a div (backdrop), or clicking with the keyboard on Escape key
the only case is mouse event when clicking the "x" close button
YossiSaadi
force-pushed
the
feat/yossi/modal-handle-show-and-on-close-logic-7368472599
branch
from
4fdff18 to
6d65e90
Compare
YossiSaadi
force-pushed
the
feat/yossi/modal-handle-show-and-on-close-logic-7368472599
branch
from
6d65e90 to
415e639
Compare
YossiSaadi
merged commit 2e0a86d
into
feat/yossi/new-modal-building-blocks-7359960492
4 of 6 checks passed
YossiSaadi
deleted the
feat/yossi/modal-handle-show-and-on-close-logic-7368472599
branch
YossiSaadi
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onCloseandshowlogicModalandModalTopActionsto be more specific for each use casehttps://monday.monday.com/boards/3532715121/pulses/7368472599