Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ModalContent): content component to be used in modal by consumers #2414

Merged
merged 3 commits into from
Sep 11, 2024
Merged

feat(ModalContent): content component to be used in modal by consumers #2414

merged 3 commits into from
Sep 11, 2024

Conversation

YossiSaadi
Copy link
Contributor

ModalContent 🌐

image

Props:

Name Type Default Description
children React.ReactNode   Can be anything

Usage example:

<ModalContent>
  Whatever you want it to be
</ModalContent>

@YossiSaadi YossiSaadi changed the base branch from master to feat/yossi/new-modal-building-blocks-7359960492 September 4, 2024 16:53
@YossiSaadi YossiSaadi marked this pull request as ready for review September 8, 2024 09:28
@YossiSaadi YossiSaadi requested a review from a team as a code owner September 8, 2024 09:28
@YossiSaadi
Merge branch 'feat/yossi/new-modal-building-blocks-7359960492' into f…
dd3bdab 
…eat/yossi/modalcontent-component-to-render-scrollable-content-inside-a-7360624571
@YossiSaadi YossiSaadi merged commit 5ff264f into feat/yossi/new-modal-building-blocks-7359960492 Sep 11, 2024
10 checks passed
@YossiSaadi YossiSaadi deleted the feat/yossi/modalcontent-component-to-render-scrollable-content-inside-a-7360624571 branch September 11, 2024 13:41
@YossiSaadi YossiSaadi mentioned this pull request Sep 11, 2024
Merged
YossiSaadi added a commit that referenced this pull request Sep 12, 2024
@YossiSaadi
feat(ModalContent): content component to be used in modal by consumers (
3f8faa6 
#2414)
YossiSaadi added a commit that referenced this pull request Oct 14, 2024
@YossiSaadi
feat(ModalContent): content component to be used in modal by consumers (
66d900c 
#2414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rivka-ungar rivka-ungar rivka-ungar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YossiSaadi @rivka-ungar