fix(SplitButton storybook): - fix stories that use wrong prop #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
reviewed
May 23, 2024
| @@ -187,7 +188,7 @@ export const SplitButtonAsThePrimaryAction = { | |||
| render: () => ( | |||
| <SplitButton | |||
| children="Use template" | |||
| secondaryPositions={SplitButton.secondaryPositions.BOTTOM_END} | |||
| secondaryDialogPosition={DialogPosition.BOTTOM_START} | |||
There was a problem hiding this comment.
You can use the secondaryDialogPosition from the SplitButton's static values. If I'm not wrong, we do not export the DialogPosition, so we want to show stories that users can just copy and use
There was a problem hiding this comment.
The issue is that the secondaryDialogPositions from the static values is of type SplitButtonSecondaryContentPosition and the secondaryDialogPosition is of type DialogPosition
There was a problem hiding this comment.
We resolved the issue by adding SplitButtonSecondaryContentPosition type to secondaryDialogPosition, and will remove the DialogPosition type in the next major release
| @@ -211,7 +212,7 @@ export const SecondarySplitButton = { | |||
| <SplitButton | |||
| children="Export to CSV" | |||
| kind={SplitButton.kinds.SECONDARY} | |||
| secondaryPositions={SplitButton.secondaryPositions.BOTTOM_MIDDLE} | |||
| secondaryDialogPosition={DialogPosition.BOTTOM_START} | |||
rivka-ungar
deleted the
SplitButton---fix-stories-that-use-wrong-prop-6495343163
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/113186840/pulses/6495343163