Skip to content

Commit

Permalink
fix(SplitButton storybook): - fix stories that use wrong prop (#2138)
Browse files Browse the repository at this point in the history
  • Loading branch information
rivka-ungar authored May 23, 2024
1 parent 118d83d commit 5f9c0a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/core/src/components/SplitButton/SplitButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ export interface SplitButtonProps extends ButtonProps {
* Class name to provide the element which wraps the popover/modal/dialog
*/
secondaryDialogClassName?: string;
secondaryDialogPosition?: DialogPosition;
// TODO in next major remove type DialogPosition
secondaryDialogPosition?: DialogPosition | SplitButtonSecondaryContentPosition;
/*
Popover Container padding size
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export const SplitButtonAsThePrimaryAction = {
render: () => (
<SplitButton
children="Use template"
secondaryPositions={SplitButton.secondaryPositions.BOTTOM_END}
secondaryDialogPosition={SplitButton.secondaryDialogPositions.BOTTOM_START}
secondaryDialogContent={
<SplitButtonMenu id="split-menu">
<MenuItem icon={Download} title="Import template" />
Expand All @@ -211,7 +211,7 @@ export const SecondarySplitButton = {
<SplitButton
children="Export to CSV"
kind={SplitButton.kinds.SECONDARY}
secondaryPositions={SplitButton.secondaryPositions.BOTTOM_MIDDLE}
secondaryDialogPosition={SplitButton.secondaryDialogPositions.BOTTOM_START}
secondaryDialogContent={
<SplitButtonMenu id="split-menu">
<MenuItem title="Export to PDF" />
Expand Down

0 comments on commit 5f9c0a4

Please sign in to comment.