-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change file extension #2086
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,13 +53,13 @@ module.exports = plop => { | |
}, | ||
{ | ||
type: "add", | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.jest.js", | ||
templateFile: "plop/general/component-snapshot-tests-jest.txt" | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.test.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the file name dropped the |
||
templateFile: "plop/general/component-snapshot-tests-test.txt" | ||
}, | ||
{ | ||
type: "add", | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.jest.js", | ||
templateFile: "plop/general/component-tests-jest.txt" | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.test.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the file name dropped the |
||
templateFile: "plop/general/component-tests-test.txt" | ||
}, | ||
{ | ||
type: "append", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you dropped the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed it completely, we don't use it anyway, we use snapshot testing inside the test files |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,14 +19,13 @@ module.exports = plop => { | |
actions: [ | ||
{ | ||
type: "add", | ||
path: | ||
"src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.jest.js", | ||
templateFile: "plop/general/component-snapshot-tests-jest.txt" | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.test.js", | ||
templateFile: "plop/general/component-snapshot-tests-test.txt" | ||
}, | ||
{ | ||
type: "add", | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.jest.js", | ||
templateFile: "plop/general/component-tests-jest.txt" | ||
path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.test.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the file name dropped the |
||
templateFile: "plop/general/component-tests-test.txt" | ||
} | ||
] | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ const commonExtends = ['plugin:react/recommended', 'plugin:prettier/recommended' | |
module.exports = { | ||
overrides: [ | ||
{ | ||
files: ['*.jest.js', 'jest.init.js'], | ||
files: ['*.test.js', 'jest.init.js'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as before, what's the meaning of it not catching ts{x} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed it as it has no effect |
||
env: { | ||
jest: true, | ||
'jest/globals': true, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not take into consideration
*.test.tsx
or*.test.ts
what is the meaning of it not catching it?