test: change file extension #2086
Conversation
| @@ -59,7 +59,7 @@ const commonExtends = ["plugin:react/recommended", "plugin:react-hooks/recommend | |||
| module.exports = { | |||
| overrides: [ | |||
| { | |||
| files: ["*.jest.js", "jest.init.js"], | |||
| files: ["*.test.js", "jest.init.js"], | |||
There was a problem hiding this comment.
it does not take into consideration *.test.tsx or *.test.ts
what is the meaning of it not catching it?
| }, | ||
| { | ||
| type: "add", | ||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.jest.js", | ||
| templateFile: "plop/general/component-tests-jest.txt" | ||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.test.js", |
There was a problem hiding this comment.
the file name dropped the jest, not replaced it with test
| @@ -53,13 +53,13 @@ module.exports = plop => { | |||
| }, | |||
| { | |||
| type: "add", | |||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.jest.js", | |||
| templateFile: "plop/general/component-snapshot-tests-jest.txt" | |||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-snapshot-tests.test.js", | |||
There was a problem hiding this comment.
the file name dropped the jest, not replaced it with test
There was a problem hiding this comment.
you dropped the jest here
There was a problem hiding this comment.
I removed it completely, we don't use it anyway, we use snapshot testing inside the test files
| }, | ||
| { | ||
| type: "add", | ||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.jest.js", | ||
| templateFile: "plop/general/component-tests-jest.txt" | ||
| path: "src/components/{{properCase componentName}}/__tests__/{{camelCase componentName}}-tests.test.js", |
There was a problem hiding this comment.
the file name dropped the jest, not replaced it with test
| @@ -39,7 +39,7 @@ const commonExtends = ['plugin:react/recommended', 'plugin:prettier/recommended' | |||
| module.exports = { | |||
| overrides: [ | |||
| { | |||
| files: ['*.jest.js', 'jest.init.js'], | |||
| files: ['*.test.js', 'jest.init.js'], | |||
There was a problem hiding this comment.
same as before, what's the meaning of it not catching ts{x}
There was a problem hiding this comment.
Removed it as it has no effect
.jest => .test