docs: allow having Internal section with stories only visible for dev mode #2062
Conversation
packages/core/.storybook/manager.jsx
Outdated
| } | ||
| } | ||
| }); | ||
|
|
||
| function filterInternalStoryDocsPage(item) { | ||
| return process.env.STORYBOOK_ENV === "development" || !item.tags?.includes?.("internal"); |
There was a problem hiding this comment.
Can't we filter the entire section without the tags?
There was a problem hiding this comment.
basically, we can say that if the name includes Internal.
I could add it as an extra check, and leave the current, just for cases where if we would like to have an internal story inside an existing category. wdyt?
There was a problem hiding this comment.
It should work also with internals stories, no? Anyway I think it's fine for now with tags. It's a new feature in SB7 no? We can use them for the beta/deprecated tags as well
There was a problem hiding this comment.
- yep it is
- you mean adding styled tags?
- and if I remove the check for
tagsand only exclude theInternalcategory, then it won't exclude internal stories that are inside regular (exported) categories
There was a problem hiding this comment.
No I mean the sidebar tags, we use the name to decide whether a story is a beta or deprecated, I think using tags is better for that purpose. Let's stay with tags, forget about what I said 😅
There was a problem hiding this comment.
ohhh I got you
TechDebt task 🙃
There was a problem hiding this comment.
packages/core/.storybook/manager.jsx
Outdated
| } | ||
| } | ||
| }); | ||
|
|
||
| function filterInternalStoryDocsPage(item) { | ||
| return process.env.STORYBOOK_ENV === "development" || !item.tags?.includes?.("internal"); |
There was a problem hiding this comment.
Storybook uses env variables, I think you can get them somehow here
There was a problem hiding this comment.
I've tried to also use their support, and their docs, couldn't find anything related
There was a problem hiding this comment.
would love to know if you find something, I'll change it 🙏🏼
There was a problem hiding this comment.
You can use process.env.NODE_ENV
There was a problem hiding this comment.
Are they setting it?
There was a problem hiding this comment.
Yes tried it locally also, and they use production for build
There was a problem hiding this comment.
what do they supply in dev?
I'm not sure if we're exporting as production build
packages/core/.storybook/manager.jsx
Outdated
| } | ||
| } | ||
| }); | ||
|
|
||
| function filterStory(item) { | ||
| console.log(process.env.NODE_ENV === "development", item.title, ...item.tags, { item }); |
YossiSaadi
deleted the
docs/yossi/Allow-hiding-internal-stories-in-Storybooks-sidebar-6437258196
branch
https://monday.monday.com/boards/3532714909/pulses/6437258196