chore(BaseInput): reusable, internal Input component #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
Apr 9, 2024
talkor
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Hmm let's discuss it
I'm leaving it open for having an Input component which would be exported from Vibe
YossiSaadi
force-pushed
the
chore/yossi/reusable-base-input
branch
from
05dfdc2 to
584dfa2
Compare
talkor
approved these changes
Apr 16, 2024
| } | ||
| } | ||
|
|
||
| &:has(.input[aria-invalid="true"]) { |
There was a problem hiding this comment.
Didn't we say we can't use has for now?
There was a problem hiding this comment.
added support for both browsers that do and do not support has
| describe("with declared props", () => { | ||
| it("should apply the size class", () => { | ||
| const { getByLabelText } = renderBaseInput({ size: "large" }); | ||
| expect(getByLabelText("base-input").parentNode).toHaveClass("large"); |
There was a problem hiding this comment.
I think you can use container or something similar to get the outer element
There was a problem hiding this comment.
container gives where the BaseInput is rendered, so I need to query the there the firstChild so it is pretty much the same..
I'll leave it the way it is I think
packages/core/src/components/BaseInput/__tests__/BaseInput.jest.tsx
Outdated
Show resolved
Hide resolved
YossiSaadi
force-pushed
the
chore/yossi/reusable-base-input
branch
from
ec1ceda to
82d9597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6437205266