Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase debounce timer on association table filter #748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glass-ships
Copy link
Collaborator

Closes #744

This PR (currently) increases the debounce from 500 to 900ms when entering text in the filter textbox.

Open to other ideas, see issue for conversation thus far

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 1f757d1
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/667c6c72f239a30008b85874
😎 Deploy Preview https://deploy-preview-748--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (c106f34) to head (1f757d1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          91       91           
  Lines        3072     3072           
=======================================
  Hits         2173     2173           
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glass-ships
Copy link
Collaborator Author

Same thing here - I seem to remember a conversation about why we didn't bring this one in at the time, but can't remember the reason...
Safe to merge / close as unplanned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback form - Ray Stefancsik - Hi team, I would like to draw attention to a usability bu...
1 participant