Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Don't use private container #29

Closed
wants to merge 1 commit into from

Conversation

siemensikkema
Copy link
Contributor

See #26

I think I removed the necessity for a private container by clearing the flashes out in the middleware. Needs testing when I have time.

@siemensikkema siemensikkema force-pushed the feature/no-private-container branch from 8c1013d to 1c67732 Compare June 21, 2018 10:30
@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #29   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           8     6    -2     
  Lines         107    84   -23     
====================================
+ Misses        107    84   -23
Impacted Files Coverage Δ
Sources/Flash/Providers/FlashProvider.swift 0% <ø> (ø) ⬆️
Sources/Flash/Models/Flash.swift 0% <ø> (ø) ⬆️
Sources/Flash/Extensions/Container+Flash.swift 0% <0%> (ø)
Sources/Flash/Tags/FlashTag.swift 0% <0%> (ø) ⬆️
Sources/Flash/Middlewares/FlashMiddleware.swift 0% <0%> (ø) ⬆️
Sources/Flash/Extensions/Future+Flash.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e190d0...1c67732. Read the comment docs.

@code28 code28 mentioned this pull request Oct 23, 2018
@tonyarnold tonyarnold mentioned this pull request Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant