-
Notifications
You must be signed in to change notification settings - Fork 11
Fix PR #29 #34
base: master
Are you sure you want to change the base?
Fix PR #29 #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
====================================
Coverage 0% 0%
====================================
Files 8 6 -2
Lines 107 84 -23
====================================
+ Misses 107 84 -23
Continue to review full report at Codecov.
|
@code28 thanks a lot for following up on this - and we're sorry for the delay. Let's have @siemensikkema go through your PR. |
@code28 Thanks for the PR! It seems the way the flashes are en/decoded to and from the session still uses the private container and the README still mentions that the private container should be used. |
Well, it seems to me, that the privateContainer is not necessary anymore. I tried removing I must admit, that I don't fully understand the principle of private containers here, but I have the impression, that we can remove it here. I can fix the readme, as soon as we found the way to go :) |
@code28 I believe that when using the normal container you use the one that is for the event loop and therefore shared by all the requests. I'd expect you'd run into problems where flashes from different requests (different users) would appear. |
Well, I just tested with two different users at the same time and not a private container, but the flashes were seperately for each user... |
I liked the idea of not having a private container (Issue #26 and Pull request #29). Since there was no development since june, I took a look and fixed two little things (one of them fixes #30), so now I think it works.
So the main work for this was done by @siemensikkema, I just made two tiny fixes to make it work. :)