Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Craftbukkit dependency and shade GSON separately. #50

Merged
merged 1 commit into from
Dec 4, 2014

Conversation

drtshock
Copy link
Contributor

@drtshock drtshock commented Dec 4, 2014

Resolves #49.

@drtshock
Copy link
Contributor Author

drtshock commented Dec 4, 2014

I did my best to keep your formatting. I didn't run my formatter because that would've made a huge diff.

I made sure this compiled but I have not attempted to run it in my Factions version.

mkremins added a commit that referenced this pull request Dec 4, 2014
Remove Craftbukkit dependency and shade GSON separately.
@mkremins mkremins merged commit 2a53da8 into mkremins:master Dec 4, 2014
@mkremins
Copy link
Owner

mkremins commented Dec 4, 2014

This looks good, thanks for contributing.

@mkremins mkremins mentioned this pull request Dec 4, 2014
@cnr
Copy link
Contributor

cnr commented Dec 5, 2014

Finding the ChatSerializer's gson instance is going to fail after this commit.

@glen3b glen3b mentioned this pull request Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSON
3 participants