Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1.8 compatible #48

Closed
MiniDigger opened this issue Nov 29, 2014 · 5 comments
Closed

Make 1.8 compatible #48

MiniDigger opened this issue Nov 29, 2014 · 5 comments

Comments

@MiniDigger
Copy link
Contributor

This this not compatible with the with spigot 1.8 since they moved Gson around (or removed it?)

I am getting an NoClassDefFoundError:

Caused by: java.lang.NoClassDefFoundError: net/minecraft/util/com/google/gson/Gson
        at mkremins.fanciful.FancyMessage.createChatPacket(FancyMessage.java:568) ~[?:?]
        at mkremins.fanciful.FancyMessage.send(FancyMessage.java:549) ~[?:?]
        at mkremins.fanciful.FancyMessage.send(FancyMessage.java:537) ~[?:?]

I'll search around where it was moved too ;D

@MiniDigger
Copy link
Contributor Author

Ah it ended you in craftbukkits lib folder:
org.bukkit.craftbukkit.libs.com.google.gson
I will submit a pull request soon ;D

@MiniDigger
Copy link
Contributor Author

Well, I though I only have to change the imports, but thats not the case...
I don't get why it's trying to search for the minecraft util but not the craftbukkit one.
Heres another stacktrace:

java.lang.NoClassDefFoundError: net/minecraft/util/com/google/gson/Gson
        at mkremins.fanciful.FancyMessage.createChatPacket(FancyMessage.java:568) ~[?:?]
        at mkremins.fanciful.FancyMessage.send(FancyMessage.java:549) ~[?:?]
        at mkremins.fanciful.FancyMessage.send(FancyMessage.java:537) ~[?:?]
        at me.MiniDigger.CraftCore.Util.CoreCommonMethods$2.run(CoreCommonMethods.java:132) ~[?:?]
        at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71) ~[spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:350) [spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:695) [spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:625) [spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:528) [spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_20]
Caused by: java.lang.ClassNotFoundException: net.minecraft.util.com.google.gson.Gson
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:91) ~[spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:86) ~[spigot-1.8-R0.1-SNAPSHOT.jar:git-Spigot-320c787]
        at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_20]
        at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_20]
        ... 11 more

@MiniDigger MiniDigger mentioned this issue Nov 29, 2014
Closed
@drtshock
Copy link
Contributor

Make sure you're building against the new spigot builds ;\

@MiniDigger
Copy link
Contributor Author

I am see

@mkremins
Copy link
Owner

mkremins commented Dec 4, 2014

Should be handled by #50, but I can't currently deploy Fanciful version 0.2.1-SNAPSHOT myself (see #51). Going to close this issue for now anyway, since the deploy issue isn't strictly related and this is a dupe of #49 (which was already auto-closed when I merged #50).

@mkremins mkremins closed this as completed Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants