Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

252 add envelope function to reliondataset #264

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

DSilva27
Copy link
Collaborator

@DSilva27 DSilva27 commented Sep 9, 2024

No description provided.

@DSilva27 DSilva27 linked an issue Sep 9, 2024 that may be closed by this pull request
@DSilva27 DSilva27 requested a review from mjo22 September 9, 2024 23:12
@mjo22
Copy link
Owner

mjo22 commented Sep 11, 2024

After the "Particle Extraction" job in relion, the rlnCtfBfactor and rlnCtfScalefactor are unestimated and all set to 0 and 1, respectively. In a case like this, do we want to read in particle stacks with these fields or just set the envelope to None?

I guess an argument for always setting them is that we may not want behavior where depending on what exactly is in the STAR file, the fields change.

@DSilva27
Copy link
Collaborator Author

Setting the bfactor to 0 and the scale to 1 will just give you something equivalent to creating the transfer theory with the envelope set as None anyway. There is not really a reason to set it up that way, except maybe computational efficiency.

@mjo22
Copy link
Owner

mjo22 commented Sep 11, 2024

Yeah, I suppose a user can always just setup a new transfer theory without the envelope if they want

@mjo22 mjo22 merged commit 295dd4a into main Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add envelope function to RelionDataset
2 participants