Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable logger from polluting other modules #1646

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Disable logger from polluting other modules #1646

merged 1 commit into from
Aug 21, 2023

Conversation

ponponon
Copy link
Contributor

#1631

The previous PR was unsigned and it was a bit of a hassle to re-sign it, so I just re-submitted the PR

@ponponon ponponon mentioned this pull request Aug 15, 2023
Closed
@mergify mergify bot added the dco-passed label Aug 15, 2023
@XuanYang-cn
Copy link
Contributor

image
@ponponon Could you please change the commit message to English with git commit --amend and rebase the latest codes to pass the Code checker actions

@ponponon
Copy link
Contributor Author

image @ponponon Could you please change the commit message to English with git commit --amend and rebase the latest codes to pass the Code checker actions

Has been changed to English

@mergify mergify bot added the ci-passed label Aug 18, 2023
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ponponon, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e353eac into milvus-io:master Aug 21, 2023
8 checks passed
@ponponon
Copy link
Contributor Author

/lgtm /approve

With this fix, I hope to be able to release a 2.2.16 to solve the 2.2.x user's nuisance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@longjiquan longjiquan Awaiting requested review from longjiquan

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ponponon @XuanYang-cn @sre-ci-robot