Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let logger.setLevel affect other modules #1631

Closed

Conversation

ponponon
Copy link
Contributor

@ponponon ponponon commented Aug 2, 2023

If you want logging.getLogger, please only affect the current module, do not change all third-party modules the same, if you do not add the name parameter in getLogger, it will cause setLevel to affect all third-party treasures, which is extremely bad and stupid

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ponponon
To complete the pull request process, please assign longjiquan after the PR has been reviewed.
You can assign the PR to them by writing /assign @longjiquan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @ponponon! It looks like this is your first PR to milvus-io/pymilvus 🎉

@XuanYang-cn
Copy link
Contributor

@ponponon Great catch!
To fix the DCO error, please follow the instruction of DCO robot to signoff this PR https://github.com/milvus-io/pymilvus/pull/1631/checks?check_run_id=15543020464

@mergify mergify bot added dco-passed and removed needs-dco labels Aug 3, 2023
@ponponon
Copy link
Contributor Author

ponponon commented Aug 3, 2023

@ponponon Great catch! To fix the DCO error, please follow the instruction of DCO robot to signoff this PR https://github.com/milvus-io/pymilvus/pull/1631/checks?check_run_id=15543020464

Add signature, help me to see if it is right, I have not done signature before, I do not know if my operation is right

@XuanYang-cn
Copy link
Contributor

@ponponon This PR is signed-off correctly.
It would be better if you could squish all of these changes together into one single commit.
This will make it easier to track changes and maintain a more organized version history

@mergify mergify bot added the ci-passed label Aug 8, 2023
@ponponon
Copy link
Contributor Author

@ponponon This PR is signed-off correctly. It would be better if you could squish all of these changes together into one single commit. This will make it easier to track changes and maintain a more organized version history

I don't know how it works. What should I do?

@XuanYang-cn
Copy link
Contributor

@ponponon try to follow the rebase part in the contributing.md https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#github-workflow

Basicly we use git rebase to merge commits into one commit. let me know if you encounter any problem. Good luck!

@ponponon
Copy link
Contributor Author

The previous PR was unsigned and it was a bit of a hassle to re-sign it, so I just re-submitted the PR:#1646

@XuanYang-cn
Copy link
Contributor

closed for dup with #1646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants