-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not let logger.setLevel affect other modules #1631
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ponponon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ponponon! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
@ponponon Great catch! |
9bca026
to
7fbc2eb
Compare
Add signature, help me to see if it is right, I have not done signature before, I do not know if my operation is right |
@ponponon This PR is signed-off correctly. |
I don't know how it works. What should I do? |
@ponponon try to follow the rebase part in the contributing.md https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#github-workflow Basicly we use |
9427b10
to
45af8e2
Compare
Signed-off-by: jiancheng <[email protected]>
45af8e2
to
ed5f5d9
Compare
The previous PR was unsigned and it was a bit of a hassle to re-sign it, so I just re-submitted the PR:#1646 |
closed for dup with #1646 |
If you want logging.getLogger, please only affect the current module, do not change all third-party modules the same, if you do not add the name parameter in getLogger, it will cause setLevel to affect all third-party treasures, which is extremely bad and stupid