-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit basic Manga information #398
base: main
Are you sure you want to change the base?
Conversation
Author, Artist, and Description are in PR already, or are you asking for other fields beyond those? |
Yeah, just saw it. I’m sleepy and I missed them before. I will delete the reply, my bad! |
Commit a745753 has a build error but I still pushed if anyone has an idea of why this is happening. I added a mihon/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt:19:66 Type mismatch: inferred type is
KFunction22<Long, Long, String, String?, String?, String?, List<String>?, String, Long, String?, Boolean, Long?, Long?, Boolean, Long, Long, Long, Long, UpdateStrategy, Long, Long, Long?, Manga>
but (Long, String?, String?, String?, String, Long, String, List<String>?, Long, String?, Boolean, Long?, Long?, Boolean, Long, Long, Long, Long, UpdateStrategy, Long, Long, Long?) -> TypeVariable(T) was expected |
Its not worth using coalesce since we would have to modify each and every database query. Take a look at how this fork does it(og field, edited field, and the standard field that takes the edited field when its not null). Also don't make it a new table, add the columns to the manga table. since there is only going to be 1 edit row per manga row. |
I believe they're using a table because that's what AntsyLich suggested in the server |
Its not worth using a table, it will just make it difficult in the long run. Columns are much easier to manage for info that needs to be attached directly to 1 object |
app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/download/DownloadHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaScreenModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupManga.kt
Outdated
Show resolved
Hide resolved
29d562d
to
cfcc359
Compare
Co-authored-by: Mitchell Syer <[email protected]>
c1e3cc3
to
925132d
Compare
Closes #5