You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that we'd need to add a toml for this, since we're getting:
Command failed due to unhandled error: Unable to find Cargo.toml
Ah, I thought I had, sorry, but I forgot it was on gitignore from the previous approach, such that it didn't get added to the commit right. Thanks for catching that!
It seems that we'd need to add a toml for this, since we're getting: Command failed due to unhandled error: Unable to find Cargo.toml
Ah, I thought I had, sorry, but I forgot it was on gitignore from the previous approach, such that it didn't get added to the commit right. Thanks for catching that!
I believe that there are still some issues with that file, judging by the build error:
error: 1 files in the working directory contain changes that were not yet committed into git:
Cargo.toml
to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag
I believe that there are still some issues with that file, judging by the build error:
error: 1 files in the working directory contain changes that were not yet committed into git:
Cargo.toml
to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag
Makes sense that would only come up in CI, yeah... not trying to publish during most local development. Let me see if I can fix by adding --allow-dirty as they suggest. In general, Rust practice would be to have the version number committed into the repo, but in general that runs counter to our CI strategy leading to this kind of minor friction.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes version injection into Rust crates to use
cargo-edit
instead ofdotnet-script
, removing the need to install .NET 5.0–specific tooling.