Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Use cargo-edit instead of dotnet-script to inject versions. #870

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cgranade
Copy link
Contributor

This PR changes version injection into Rust crates to use cargo-edit instead of dotnet-script, removing the need to install .NET 5.0–specific tooling.

@ricardo-espinoza
Copy link
Contributor

It seems that we'd need to add a toml for this, since we're getting:

Command failed due to unhandled error: Unable to find Cargo.toml

@cgranade
Copy link
Contributor Author

It seems that we'd need to add a toml for this, since we're getting:

Command failed due to unhandled error: Unable to find Cargo.toml

Ah, I thought I had, sorry, but I forgot it was on gitignore from the previous approach, such that it didn't get added to the commit right. Thanks for catching that!

@ricardo-espinoza
Copy link
Contributor

It seems that we'd need to add a toml for this, since we're getting:
Command failed due to unhandled error: Unable to find Cargo.toml

Ah, I thought I had, sorry, but I forgot it was on gitignore from the previous approach, such that it didn't get added to the commit right. Thanks for catching that!

I believe that there are still some issues with that file, judging by the build error:

error: 1 files in the working directory contain changes that were not yet committed into git:
       Cargo.toml

to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag

@cgranade
Copy link
Contributor Author

I believe that there are still some issues with that file, judging by the build error:

error: 1 files in the working directory contain changes that were not yet committed into git:
       Cargo.toml

to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag

Makes sense that would only come up in CI, yeah... not trying to publish during most local development. Let me see if I can fix by adding --allow-dirty as they suggest. In general, Rust practice would be to have the version number committed into the repo, but in general that runs counter to our CI strategy leading to this kind of minor friction.

@ricardo-espinoza
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@cgranade
Copy link
Contributor Author

Build failures seem to be related to macOS failures more generally, and not to changes in this PR; let's rerun once those are fixed, perhaps?

@kuzminrobin
Copy link
Contributor

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants