This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Initial support for matrix inverse in qdk_sim_experimental crate #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
force-pushed
the
cgranade/expm-rs
branch
from
7b876c8 to
e1b3cdf
Compare
cgranade
changed the title
|
This PR has been updated to use a pure-Rust implementation of |
kuzminrobin
approved these changes
Apr 2, 2022
|
@kuzminrobin: Thanks! If you're curious about any of the Rust-y parts, I'd be happy to sync with you and go over in more detail. In the meantime, @swernli and @SamarSha, if you have any comments on Rust-specific points I'd greatly appreciate your feedback. Thanks! |
bamarsha
reviewed
Apr 4, 2022
swernli
approved these changes
Apr 5, 2022
|
@SamarSha: Wanted to double-check that all your feedback has been addressed before merging. Thanks! |
|
Yes, looks good, thanks. |
|
Awesome, thank you for all your detailed feedback! 💕 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins work on #915 by adding a pure-Rust implementation of LU decompositions and matrix inverses, drawing from the MIT-licensed examples at https://github.com/cgranade/cursed-linalg. These linear algebra routines will be needed in order to implement
expmwithout passing a LAPACK dependency through to end users.The PR will appear very messy until #979 is merged, as it includes unrelated changes from
main.Note that this PR targets a feature branch, and further work on unit tests, integration tests, and perf benchmarks are expected before that feature is merged to main.