fix: stop global setup when debugger is terminated attempt #2 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Oct 7, 2024
src/extension.ts
Outdated
| testRun.token.onCancellationRequested(() => debugEnd.cancel()); | ||
|
|
||
| let mainDebugRun: vscodeTypes.DebugSession | undefined; | ||
| this._vscode.debug.onDidStartDebugSession(session => { mainDebugRun ??= session; }); |
There was a problem hiding this comment.
Let's check the session.name to be our own.
src/extension.ts
Outdated
| @@ -534,7 +534,19 @@ export class Extension implements RunHooks { | |||
| }; | |||
|
|
|||
| if (mode === 'debug') { | |||
| await model.debugTests(items, testListener, testRun.token); | |||
| const debugEnd = new this._vscode.CancellationTokenSource(); | |||
There was a problem hiding this comment.
I now think we should move this code to the place that calls vscode.debug.startDebugging, instead of having it here.
mxschmitt
reviewed
Oct 7, 2024
dgozman
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #525, which got reverted.
The problem was that we were stopping everything as soon as the first debug session stops. It turns out that there's more than one debug session though! The child process that's used to evaluate
playwright.config.tsgets its own child debug session. Once it successfully closes, theonDidTerminateDebugSessionhandler is executed. In the past attempt, this closed debugging.The fix is to only call
debugEnd.cancel()if the main debug session is closed.Closes microsoft/playwright#32387