Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal]: vscode debugging is broken in unreleased version #32710

Closed
mxschmitt opened this issue Sep 19, 2024 · 3 comments
Closed

[internal]: vscode debugging is broken in unreleased version #32710

mxschmitt opened this issue Sep 19, 2024 · 3 comments
Labels

Comments

@mxschmitt
Copy link
Member

mxschmitt commented Sep 19, 2024

Not possible to debug todomvc after microsoft/playwright-vscode@4328be9

Repro: Set a breakpoint in should allow me to add todo items and try to debug it.

@mxschmitt
Copy link
Member Author

Note:

      this._vscode.debug.onDidTerminateDebugSession(() => {
        debugEnd.cancel()
      });

is getting called and causing the debugging session to end.

@Skn0tt
Copy link
Member

Skn0tt commented Sep 27, 2024

Whew, good job catching this! I've investigated and it seems that our main debug run spawns multiple "debug sessions" underneath. The child process that's used to evaluate the config gets its own "debug session", and as it sucessfully closes the session calls onDidTerminateDebugSession. I'll see if we can limit this to only listen for the main debug run.

@Skn0tt
Copy link
Member

Skn0tt commented Sep 27, 2024

Here's another attempt: microsoft/playwright-vscode#537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants