Generate symbols for all Go toolchain binaries #1210
Conversation
| @@ -124,16 +138,21 @@ stages: | |||
| - pwsh: Write-Host "##vso[task.setvariable variable=GOARM]6" | |||
| displayName: Set GOARM for cross-compile | |||
|
|
|||
| - ${{ if eq(variables.createPDB, true) }}: | |||
There was a problem hiding this comment.
Interesting... wasn't aware job variables would be accessible here. (I experienced pipeline variables not being accessible inside a stage template in go-images, but it seems now that that's because that stage's variables are the ones that are in scope at that point, excluding the outer variables.)
https://learn.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#variables seems very vague about it, but another thing it mentions is that they're evaluated in order... so maybe some of the value reuse we're currently doing through layers of templates could be done this way too.
No suggestion to change anything now, just some context about why this isn't showing up anywhere else. 😄
Co-authored-by: Davis Goodin <[email protected]>
Generate symbols for all Go toolchain binaries (cherry picked from commit ee78796 with conflict resolution due to not using distpack)
Generate symbols for all Go toolchain binaries (cherry picked from commit ee78796)
Generate symbols for all Go toolchain binaries (cherry picked from commit ee78796 with conflict resolution due to not using distpack)
Note
This PR uses a PDB generation tool, gopdb, which is still experimental and not available publicly.
This PR adds support for publishing symbols in the form of PDBs. It is enabled by default for the
rolling-internalpipeline.This is a summary of the changes:
gopdbtool for all the Go toolchain binaries.publish-stage.ymlexecution tobuilders-to-stages.yml, as it now needs to know which builders were run in order to download the symbol artifacts they published.See these changes in action in https://dev.azure.com/dnceng/internal/_build/results?buildId=2439083&view=results.