PIX: split vector alloca writes to enable debug instrumentation #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanp
reviewed
Nov 19, 2024
There was a problem hiding this comment.
LGTM, but we should get a review from someone more familiar with all of this. @adam-yang perhaps?
Is there a reason that the testing for this isn't filecheck based?
adam-yang
reviewed
Nov 19, 2024
adam-yang
reviewed
Nov 19, 2024
adam-yang
reviewed
Nov 19, 2024
adam-yang
reviewed
Nov 19, 2024
adam-yang
reviewed
Nov 19, 2024
adam-yang
reviewed
Nov 19, 2024
adam-yang
requested changes
Nov 19, 2024
Yes: you can't get the textual pass "printf" output via filecheck. |
damyanp
approved these changes
Dec 4, 2024
|
Still LGTM - changing my review into an approval! |
jeffnn
added a commit
to jeffnn/DirectXShaderCompiler
that referenced
this pull request
Dec 5, 2024
…osoft#6990) Bit of background: PIX's debug passes add new allocas, stores to which tie debug info to DXIL Values. In the case of a preexisting alloca, PIX will still add its debug writes, but the codegen may have emitted vector-valued stores. Concretely, this happens for the ray payload and RayDesc structs in DXR. Those vector-values stores were being treated incorrectly, resulting in missing values in the PIX shader debugger. This change splits vector-valued stores to such allocas into extractelement/scalar-stores, which enables the rest of the PIX instrumentation to function as expected. (Worth noting that this change only applies to the PIX shader debugging pass.) (cherry picked from commit a03a77f)
jeffnn
added a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of background: PIX's debug passes add new allocas, stores to which tie debug info to DXIL Values.
In the case of a preexisting alloca, PIX will still add its debug writes, but the codegen may have emitted vector-valued stores. Concretely, this happens for the ray payload and RayDesc structs in DXR. Those vector-values stores were being treated incorrectly, resulting in missing values in the PIX shader debugger.
This change splits vector-valued stores to such allocas into extractelement/scalar-stores, which enables the rest of the PIX instrumentation to function as expected.
(Worth noting that this change only applies to the PIX shader debugging pass.)