PIX: Cherry pick (split vector writes, and SAT pass returns modification status) #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft#6990) Bit of background: PIX's debug passes add new allocas, stores to which tie debug info to DXIL Values. In the case of a preexisting alloca, PIX will still add its debug writes, but the codegen may have emitted vector-valued stores. Concretely, this happens for the ray payload and RayDesc structs in DXR. Those vector-values stores were being treated incorrectly, resulting in missing values in the PIX shader debugger. This change splits vector-valued stores to such allocas into extractelement/scalar-stores, which enables the rest of the PIX instrumentation to function as expected. (Worth noting that this change only applies to the PIX shader debugging pass.) (cherry picked from commit a03a77f)
…ed anything (microsoft#7010) The SAT pass will now report a string when it finds that no resource access was performed by a module. This solves two issues. -The SAT pass, when operating on a shader that has no resource access, will add a resource declaration for the PIX output UAV. This becomes a problem for PIX in terms of juggling root signatures and/or root parameters. -SAT is a notoriously time-consuming operation in PIX, so if the SAT pass can report that its results do not need to be re-packaged into a new container for passing to the d3d API, then PIX can avoid the overhead of doing so. But of course we need to be careful that the SAT pass doesn't erroneously report that it didn't modify the module when in fact it did, cuz then PIX would fail to notice some dynamic resource accesses. That's what the tests are for. (cherry picked from commit 848b7c4)
adam-yang
approved these changes
Dec 5, 2024
damyanp
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PRs:
#6990
(cherry picked from commit a03a77f)
#7010
(cherry picked from commit 848b7c4)