-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend testing of JS runtime limits #5594
Merged
eddyashton
merged 12 commits into
microsoft:main
from
eddyashton:test_js_runtime_limits
Sep 19, 2023
Merged
Extend testing of JS runtime limits #5594
eddyashton
merged 12 commits into
microsoft:main
from
eddyashton:test_js_runtime_limits
Sep 19, 2023
+114
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_js_runtime_limits@75982 aka 20230919.7 vs main ewma over 20 builds from 75578 to 75972 Click to see tablemain
test_js_runtime_limits
|
jumaffre
approved these changes
Aug 30, 2023
eddyashton
added a commit
that referenced
this pull request
Sep 21, 2023
This reverts commit d94b3f5.
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Oct 24, 2023
(cherry picked from commit d94b3f5) # Conflicts: # tests/js-custom-authorization/custom_authorization.py
achamayou
added a commit
that referenced
this pull request
Oct 24, 2023
Loading
Loading status checks…
#5766) Co-authored-by: Eddy Ashton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve confidence in JS runtime limits following interpreter reuse investigation. This PR extends the existing tests to set a too-low value for each limit, and confirm that causes an isolated failure, as well as testing a too-large-for-the-default value. I've also moved the execution time limit to the limit tests, rather than testing it separately in
modules
.