-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for QuickJS runtime options #4371
Comments
@achamayou Julien pointed out the existing test for this https://github.com/microsoft/CCF/blob/main/tests/js-custom-authorization/custom_authorization.py#L43-L69 The test values don't seem to match with the defaults set in the code though. I'm not yet sure at this point how the default values were derived. Edit: On taking another look at it, the test values don't have to match the defaults. but still unsure on how the original defaults were derived. |
@MahatiC the idea is to allocate a lot less (*) than the limit, check it works, and more than the limit, and check it fails. (*) too close and it will fail, because there will be other allocations we can't precisely control etc. Ideally this test would call an endpoint that exposes the value, or use the config directly, and compute the values as |
For the stack size limit, an (large) recursive call is probably the best way to go. |
Sure that makes sense, and I assume the current default heap size of 100 * 1024 * 1024 in the code was derived empirically? |
Yes, I think it was our default enclave heap size for a long time. |
As mentioned here #4344 (comment)
The text was updated successfully, but these errors were encountered: