Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Core from crashing due to uncaught exceptions #173

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Prevent Core from crashing due to uncaught exceptions #173

merged 5 commits into from
Mar 7, 2022

Commits on Mar 7, 2022

  1. Add unit tests for MMCore crashes 

    Most of these fail (except APIErrorTests.GetPixelSizeUmWithNoConfig).
    @marktsuchida
    marktsuchida committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    98bf517 View commit details
    Browse the repository at this point in the history

  2. Prevent MMCore crash by uncaught exceptions 

    And, in one case, a null pointer.

Did not fix PropertyBlock functions which should be deprecated.
    @marktsuchida
    marktsuchida committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    9afd47e View commit details
    Browse the repository at this point in the history

  3. Deprecate MMCore property block functions 

    It is not clear to me what these were intended for, but they are
probably part of a planned but unfinished feature (seeing that it
appears to be tied to an Equipment command in config files, which, as
far as I know, was never supported by the Hardware Configuration
Wizard).

Some of the functions deprecated here may crash when called with
incorrect parameters.
    @marktsuchida
    marktsuchida committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    9cca84e View commit details
    Browse the repository at this point in the history

  4. Deprecate MMCore ImageSynchro functions 

    Among other things, it doesn't even do what it says because it only
applies to snap, not to sequence acquisition.

ImageSynchro has not been used by MMStudio for a long time.

Apps can simply wait for individual devices as needed.
    @marktsuchida
    marktsuchida committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fe13c34 View commit details
    Browse the repository at this point in the history

  5. Increment MMCore minor version 

    This is for the new guaranteed behavior on errors for a few functions,
and the deprecation of PropertyBlock and ImageSynchro functions.
    @marktsuchida
    marktsuchida committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4f32845 View commit details
    Browse the repository at this point in the history