Prevent Core from crashing due to uncaught exceptions #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests to be written before this is ready. |
Most of these fail (except APIErrorTests.GetPixelSizeUmWithNoConfig).
And, in one case, a null pointer. Did not fix PropertyBlock functions which should be deprecated.
It is not clear to me what these were intended for, but they are probably part of a planned but unfinished feature (seeing that it appears to be tied to an Equipment command in config files, which, as far as I know, was never supported by the Hardware Configuration Wizard). Some of the functions deprecated here may crash when called with incorrect parameters.
Among other things, it doesn't even do what it says because it only applies to snap, not to sequence acquisition. ImageSynchro has not been used by MMStudio for a long time. Apps can simply wait for individual devices as needed.
marktsuchida
force-pushed
the
core-uncaught-exceptions
branch
from
0c5e677
to
fe13c34
Compare
This is for the new guaranteed behavior on errors for a few functions, and the deprecation of PropertyBlock and ImageSynchro functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #165.
Closes #105.
throw (CMMError)PropertyBlock, a seldom (never?) used feature, many of which will potentially crash