Update wet bulb freezing level cube name #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by hail_size cli.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1956 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 123 123
Lines 11808 11808
=======================================
Hits 11618 11618
Misses 190 190 ☔ View full report in Codecov by Sentry. |
MoseleyS
approved these changes
Oct 13, 2023
2 tasks
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…ed by hail_size cli. (metoppv#1956) Co-authored-by: Marcus Spelman <[email protected]> This doesn't need a second review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the wet bulb freezing level cube is called "wet_bulb_freezing_level". However the hail size cli requires the name the be "wet_bulb_freezing_level_altitude" to extract it from a cubelist.
This PR updates the cube name so it can be used with the hail size plugin.
Updated acceptance test data: metoppv/improver_test_data#35
Testing: