Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates checksums for WBFL KGO #1957

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

MoseleyS
Copy link
Contributor

Following #1956

The above PR had an associated change to acceptance test data (metoppv/improver_test_data#35), but the checksums were not updated, and the testing was insufficient (my fault! sorry).

This PR updates the checksum for the modified file.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@MoseleyS MoseleyS requested a review from mspelman07 October 13, 2023 13:10
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2520f58) 98.39% compared to head (a6b3478) 98.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1957   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         123      123           
  Lines       11814    11814           
=======================================
  Hits        11624    11624           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoseleyS MoseleyS merged commit 6382d00 into metoppv:master Oct 13, 2023
@MoseleyS MoseleyS deleted the wbfl_kgo_checksum branch October 13, 2023 13:51
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants