Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node's --inspect debugger to port detection #2981

Merged
merged 17 commits into from
Dec 19, 2024
Merged

Add node's --inspect debugger to port detection #2981

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9ca58ae
change get_port to return Vec instead of Option
gememma Dec 16, 2024
07f3970
Adjust calls to get_port to accept Vec
gememma Dec 16, 2024
ae91837
Add changelog
gememma Dec 16, 2024
204e1c5
Add tests for node inspector port detection
gememma Dec 16, 2024
57e8770
Various
gememma Dec 16, 2024
5b49457
Change get_ports to take get_env fn
gememma Dec 16, 2024
5c3980b
Allow MIRRORD_IGNORE_DEBUGGER_PORTS to contain multiple port numbers
gememma Dec 16, 2024
f95f0b5
Fix comment
gememma Dec 16, 2024
c24f941
Various
gememma Dec 16, 2024
7ed6a3c
Add default inspector port as fallback
gememma Dec 17, 2024
788e95e
Allow detection of multiple ports for inspector
gememma Dec 18, 2024
6013bd1
Fix tests and format
gememma Dec 18, 2024
e6abf76
Clippy
gememma Dec 18, 2024
6372d38
Change Detected to Single variant
gememma Dec 19, 2024
07da3fb
Move port parsing logic to impl FromStr and impl Display
gememma Dec 19, 2024
9e064f3
Use FromStr and Display to set env var
gememma Dec 19, 2024
4edfebd
Make DebuggerPorts FromStr infallible
gememma Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/2936.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added debugger port detection type for the node `--inspect`, `--inspect-wait` and `--inspect-brk` flags
Loading
Loading