Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node's --inspect debugger to port detection #2981

Conversation

gememma
Copy link
Member

@gememma gememma commented Dec 16, 2024

No description provided.

@Razz4780 Razz4780 self-requested a review December 16, 2024 11:57
mirrord/config/src/util.rs Outdated Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
@gememma gememma requested a review from Razz4780 December 16, 2024 15:26
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gememma gememma enabled auto-merge December 16, 2024 15:57
@gememma gememma disabled auto-merge December 16, 2024 16:09
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Left some optional suggestions

mirrord/layer/src/debugger_ports.rs Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Outdated Show resolved Hide resolved
mirrord/layer/src/debugger_ports.rs Show resolved Hide resolved
@gememma gememma enabled auto-merge December 19, 2024 12:20
@gememma gememma added this pull request to the merge queue Dec 19, 2024
Merged via the queue into metalbear-co:main with commit 254f7cc Dec 19, 2024
17 checks passed
@gememma gememma deleted the gemma/mbe-535-mirrord-vscode-templating-seems-to-get-ide-to-hang branch December 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants