Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tomcat Plugin #303

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fix Tomcat Plugin #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8411dc5
fix
t4lz Nov 28, 2024
88b9919
Change changelog for towncrier, but not adding new
t4lz Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/230.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Tomcat executions are now stopped when mirrord setup fails.
Tomcat executions now get stopped when mirrord setup fails.
4 changes: 2 additions & 2 deletions ...s/tomcat/src/main/kotlin/com/metalbear/mirrord/products/tomcat/TomcatExecutionListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ class TomcatExecutionListener : ExecutionListener {
val startupInfoField =
RunnerSpecificLocalConfigurationBit::class.java.getDeclaredField("myStartupInfo")
startupInfoField.isAccessible = true
startupInfoField.set(config, patchedStartupInfo)
startupInfoField.set(config.first, patchedStartupInfo)
} else {
MirrordLogger.logger.debug("[${this.javaClass.name}] processStartScheduled: NOT using default - patching by changing the non-default script")
config.first.startupInfo.SCRIPT = it
Expand Down Expand Up @@ -255,7 +255,7 @@ class TomcatExecutionListener : ExecutionListener {
MirrordLogger.logger.debug("[${this.javaClass.name}] restoreConfig: found saved script info")
val startupInfoField = RunnerSpecificLocalConfigurationBit::class.java.getDeclaredField("myStartupInfo")
startupInfoField.isAccessible = true
startupInfoField.set(config, savedScriptInfo)
startupInfoField.set(config.first, savedScriptInfo)
}

MirrordLogger.logger.debug("[${this.javaClass.name}] restoreConfig: removing before run task")
Expand Down