Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tomcat Plugin #303

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fix Tomcat Plugin #303

merged 2 commits into from
Nov 28, 2024

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Nov 28, 2024

Fix #302

I was not getting the exact same phenomenon as in the issue, but after this change the plugin works fine for Tomcat on macOS. I'm getting layer logs, I can get the weird broken Tomcat responses over an external port on the cluster, etc.

image
image
image

@t4lz t4lz requested a review from Razz4780 November 28, 2024 00:20
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the beauty of forced field access

@Razz4780 Razz4780 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into metalbear-co:main with commit 1c27535 Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tomcat execution does nothing on macOS (unreleased)
2 participants