Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mounting custom query modules #67

Merged
merged 4 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions charts/memgraph/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ spec:
persistentVolumeClaim:
claimName: {{ include "memgraph.fullname" . }}-user-storage
{{- end }}
{{- range .Values.customQueryModules }}
- name: {{ .volume | quote }}
configMap:
name: {{ .volume | quote }}
{{- end }}


containers:
- name: memgraph
Expand Down Expand Up @@ -186,6 +192,11 @@ spec:
- name: {{ include "memgraph.fullname" . }}-user-storage
mountPath: {{ .Values.persistentVolumeClaim.userMountPath }}
{{- end }}
{{- range .Values.customQueryModules }}
- name: {{ .volume | quote }}
mountPath: {{ printf "/var/lib/memgraph/internal_modules/%s" .file }}
subPath: {{ .file | quote }}
{{- end }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
9 changes: 9 additions & 0 deletions charts/memgraph/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,12 @@
initialDelaySeconds: 10
periodSeconds: 10
failureThreshold: 30

# List of custom query modules to be mounted into the app.
# These will be loaded automatically, on startup.
# Each module must be exposed by a ConfigMap under a specific file name.
customQueryModules: []
# Must be an existing ConfigMap
# - volume: ""
# Must be present in the ConfigMap referenced with `volume`
# file: ""

Check failure on line 146 in charts/memgraph/values.yaml

View workflow job for this annotation

GitHub Actions / lint-test

146:13 [new-line-at-end-of-file] no new line character at the end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add empty line here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix this so the action can be re-run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, sorry about that. Added the line

Loading