Add support for mounting custom query modules #67
Conversation
matkob
requested review from
antejavor,
katarinasupe and
as51340
as code owners
charts/memgraph/values.yaml
Outdated
| # Must be an existing ConfigMap | ||
| # - volume: "" | ||
| # Must be present in the ConfigMap referenced with `volume` | ||
| # file: "" |
There was a problem hiding this comment.
just add empty line here
There was a problem hiding this comment.
We need to fix this so the action can be re-run.
There was a problem hiding this comment.
Ahh, sorry about that. Added the line
There was a problem hiding this comment.
Hi @matkob thanks a lot for this contribution. 🚀 Let's just fix the empty space, so we can re-run the test.
If I understood correctly, you would have something like this:
values.yaml
customQueryModules:
- volume: "module-volume-1"
file: "module1.py"
- volume: "module-volume-2"
file: "module2.py"
Template:
- name: "module-volume-1"
mountPath: "/var/lib/memgraph/internal_modules/module1.py"
subPath: "module1.py"
- name: "module-volume-2"
mountPath: "/var/lib/memgraph/internal_modules/module2.py"
subPath: "module2.py"
We obviously do not have a clear way of adding this, except maybe user defined volume here.
I am curious if you can comment on what is the benefit of having a volume per QM for you?
Just asking, since I didn't have a chance to use QMs + k8s, so I am curious about the flow and why did you configure it this way.
charts/memgraph/values.yaml
Outdated
| # Must be an existing ConfigMap | ||
| # - volume: "" | ||
| # Must be present in the ConfigMap referenced with `volume` | ||
| # file: "" |
There was a problem hiding this comment.
We need to fix this so the action can be re-run.
|
Hi @antejavor, good question! Initially I wanted to create and mount only one ConfigMap with all the custom query modules inside, potentially even stored in multiple files. Unfortunately I bumped into issues related to how Kubernetes mounts the volumes - it adds timestamp to the mountPath and creates a symlink. This would end up in QM not working in memgraph (they would be duplicated and memgraph wouldn't load the code properly). Mounting each QM separately, using subPath, fixed the issue and the workaround didn't seem "too dirty" to me. Let me know if this seems sound to you, too :) |
Mounting each QM via separate volume --------- Co-authored-by: antejavor <[email protected]>
Closes #66